Skip to content

Add a better ICINGA Webui output und a new argument --no-early-break to disable the early break - #1141

Closed
TheCry wants to merge 4 commits into
Linuxfabrik:mainfrom
TheCry:main
Closed

Add a better ICINGA Webui output und a new argument --no-early-break to disable the early break#1141
TheCry wants to merge 4 commits into
Linuxfabrik:mainfrom
TheCry:main

Conversation

@TheCry

@TheCry TheCry commented May 20, 2026

Copy link
Copy Markdown

For the ICINGA WebUI, the statuses "OK, WARNING, CRITICAL, and UNKNOWN" have been added to the output. This makes it easy to see at a glance what the status is.

The second patch introduces a new argument to disable "early break." By default, it is enabled.

markuslf added a commit that referenced this pull request Sep 21, 2026
@markuslf
feat(file-count): add --no-early-break to count every matching file
1d2143a 
With numeric thresholds, file-count stops counting once the count exceeds
the highest threshold, so the file_count perfdata is capped at that
threshold + 1 and graphs go flat exactly when a directory grows.
--no-early-break disables the shortcut and counts every file.

Suggested by @TheCry in #1141.
@markuslf

markuslf commented Sep 21, 2026

Copy link
Copy Markdown
Member

Hi @TheCry, thanks for the PR and sorry for the long silence.

  • State prefix ([OK], [WARNING], ...): we'll leave this out. None of our plugins prefix the message with the state, and Icinga Web already shows it. Since this PR was opened, file-count also names the range that was violated and appends the state to it, e.g. Found 150 matching files, 150 not in (0..100) [WARNING]. With the prefix, the state would appear twice.
  • --no-early-break: good point. With early break active, the file_count perfdata is capped at the threshold + 1, so graphs go flat exactly when the directory grows. Your branch now conflicts with main, so we'll implement the option directly on main (plus README, CHANGELOG and a test) and credit you for it.

@markuslf markuslf closed this Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TheCry @markuslf